This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Remove placeholder #250
Merged
Remove placeholder #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `latest_vdf_outputs`, `persistent_committees`, `persistent_committee_reassignments`, and `custody_challenges` from `BeaconState` * Remove `custody_reseeds`, `custody_challenges`, and `custody_responses` from `BaseBeaconBlock`
hwwhww
force-pushed
the
remove_placeholder
branch
from
b4d5cd9
to
cc79ed0
Compare
hwwhww
force-pushed
the
remove_placeholder
branch
from
cc79ed0
to
ff9b7fc
Compare
…ion` to imply that it's not as same as the spec `verify_slashable_attestation`
|
There's a spec change of |
NIC619
reviewed
Feb 6, 2019
Co-Authored-By: hwwhww <hwwang156@gmail.com>
ralexstokes
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #244
How was it fixed?
ValidatorIndexfromuint24touint64SlashableAttestationandverify_slashable_attestationlogic.verify_slashable_attestation(spec: https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#verify_slashable_attestation) tovalidate_slashable_attestation- it raisesValidatationErrorwhen it's invalidverify_bitfield(spec: https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#verify_bitfield) and change it tovalidate_bitfield- it raisesValidatationErrorwhen it's invalidlatest_vdf_outputs,persistent_committees,persistent_committee_reassignments, andcustody_challengesfromBeaconStatecustody_reseeds,custody_challenges, andcustody_responsesfromBaseBeaconBlockcustody_commitmentfromValidatorRecordandDepositInputCute Animal Picture